refactor(cwl): Remove LiveTail specific limit preference, rename scheme, improve exception messaging #5831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeganirby
changed the title
justinmk3
reviewed
Oct 22, 2024
| } catch (err) { | ||
| throw new ToolkitError('Caught on-stream exception') | ||
| throw new ToolkitError( | ||
| `Encountered LiveTail on-stream failure for session ${session.uri}: ${(err as Error).message}` |
Contributor
There was a problem hiding this comment.
I would suggest not catching the error at all, just let it bubble up. please review our guidelines.
if you must catch and re-throw this, then it's usually a good idea to use ToolkitError.chain so that the original error is part of its chain.
justinmk3
approved these changes
Oct 22, 2024
Contributor
justinmk3
left a comment
justinmk3
left a comment
There was a problem hiding this comment.
lgtm after toolkiterror.chain() or bubble up
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
…ws#5831 * Remove CWL LiveTail limit setting. Instead pulls from existing limit preference. Updated description of limit preference to describe LiveTail line trimming behavior * Rename CWL Scheme variable to fit linting rules * Bubble up exception instead of rethrowing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Addresses some feedback on past PRs
Solution
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.